India
Joined: Jan 12, 2015
Post Count: 62
Status:
Offline
Re: Progress and time of photo rendering
I just downloaded and used the photo plug-in. It is really impressive. But can we select the rendering engine or is it constant. Does it work with the advanced photo rendering settings also. One more, if it could give the total time required to render the scene, it would be great. Asking too much though. :)
Joined: May 28, 2015
Post Count: 607
Status:
Offline
Re: Progress and time of photo rendering
Version 1.0 of the plug-in that was renamed uses the same rendering engine as the photo creation pane integrated in Sweet Home 3D. It is therefore compatible with the advanced settings.
----------------------------------------
EnkoNyito
Netherlands
Joined: Sep 26, 2009
Post Count: 3952
Status:
Offline
Re: Progress and time of photo rendering
Enko,
I have now installed SH3D v5.2a, as well as Advanced Settings for Photo Rendering 1.3, and Advanced Photo Rendering 1.0.
When I render a picture using Create Photo, I can see the large "pixels" in the rendering preview, showing me that this is the original SH3D render engine using the "new" 64 pixel buckets.
When I change the settings using Tools -> Advanced Settings of Photo Rendering, SH3D still uses the SH3D render engine, because I can see the large "pixels".
However, when I use Tools -> Advanced Photo Rendering a new render window opens which uses the older, smaller buckets and renders in lines, instead of a spiral. I can even render two images at the same time.
Question: would it be possible to make the plug-in use the "officially" installed version of SH3D, so that the timer plug-in just adds the timer to the original version of SH3D? The reason for this request is that Windows 10 overwrites the previouw version(s) of SH3D, and allows only the latest version. Previously I used Ubuntu, and there I had 5-10 versions of SH3D on my computer side by side, so that I could easily switch from one version to the other. No doubt this can be done in W10 also, it's just too complicated for my simple mind.
Hans
----------------------------------------
Hans
----------------------------------------
EnkoNyito
----------------------------------------
[Edit 1 times,
last edit by enkonyito at Mar 12, 2016, 7:49:07 PM]
Joined: May 28, 2015
Post Count: 607
Status:
Offline
Re: Progress and time of photo rendering
Hans,
As mentioned in this thread , a plug-in can not modify a program interface. That is why you have found these differences and I did not use the same Sunflow configuration (buckets order, buckets size, etc...).
Perhaps by making a request, the progress and rendering time will be included in the original program.
----------------------------------------
EnkoNyito
France
Joined: Nov 7, 2005
Post Count: 9181
Status:
Offline
Re: Progress and time of photo rendering
If you want to update the plug-in on SourceForge.net, just edit your initial comment there and delete the existing attachement and add a new one. Don't you have access to these tools?
By the way, thanks for trying to improve the existing renderer, but could you give some details about what you changed? Please add some comments in your source files with GNU GPL headers and notices about the changes you made compared to original source files? The section 2 of this license states how you should proceed when you make some changes to some existing source code.
I'm not convinced about the progress bar in Sweet Home 3D photo creation tool, mainly because it will hardly give precise results. As soon as the Sunflow is working on rendering glasses, you know that it takes much longer and you can't guess it. I know that the the progress bar in Sweet Home 3D video creation tool is not precise too, but it was added there first for user's feedback purpose, whereas in the photo creation tool, the feedback is already shown with the buckets.
----------------------------------------
Emmanuel Puybaret, Sweet Home 3D developer
Netherlands
Joined: Sep 26, 2009
Post Count: 3952
Status:
Offline
Re: Progress and time of photo rendering
When making test renders, people tend to compare the time one test takes with the time of another test. Especially in Q4, rendering can take a long time. Longer than one is willing to wait and watch the screen to time the duration. A built-in timer would give the time, while people can make coffee, take a shower or go shopping.
Joined: May 28, 2015
Post Count: 607
Status:
Offline
Re: Progress and time of photo rendering
Emmanuel,
On SourceForge, I can only edit comments in discussion.
Information about the GNU GPL license and the changes made to the SH3D source code have been added to the plug-in Java sources. Compared to the original photo panel, the plug-in allows : - a display of buckets in row with the same visual size regardless of the image width - ceiling lights a little less dazzling and sometimes centered differently - rendering aerial view identical to that in virtual visit - a reduced number of samples in global illumination "path"
For sure the buckets gives an idea of the progress but the progress bar can also be useful for an ipr rendering. The elapsed time is a further indication even if the estimated remaining time is less accurate.
----------------------------------------
EnkoNyito
France
Joined: Nov 7, 2005
Post Count: 9181
Status:
Offline
Re: Progress and time of photo rendering
I renamed the ticket of this plug-in for you. Thanks for the comments in SunflowRenderer.java and AdvancedPhotoPanel.java classes showing the changes you made. Just one missing thing for next time: you should mention where these classes come from, and add the original @author tags of these classes. The idea behind these requirements is that anybody who wants to keep track of the changes you made should be able to find your sources.
----------------------------------------
Emmanuel Puybaret, Sweet Home 3D developer